Skip to content

fix: Replace inline cursor style with CSS classes to resolve CSP violation #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Who-is-PS merged 4 commits into from
Mar 5, 2026
Merged

fix: Replace inline cursor style with CSS classes to resolve CSP violation #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a197d0
fix of cursor pointer
Who-is-PS Mar 3, 2026
ffe7e02
fix: resolve CSP violation caused by inline style attributes on SVG e…
Who-is-PS Mar 4, 2026
e7107ae
Delete docs/in-operator-review-AWSUI-59006.md
Who-is-PS Mar 4, 2026
fac8903
Delete docs/tech-proposal-in-operator-audit.md
Who-is-PS Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/core/chart-api/chart-extra-pointer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,15 +186,9 @@ export class ChartExtraPointer {

private applyCursorStyle = () => {
const container = this.context.chart().container;
const setCursor = (value: "pointer" | "default") => {
if (container && container.style.cursor !== value) {
container.style.cursor = value;
}
};
if (this.hoveredPoint || this.hoveredGroup) {
setCursor("pointer");
} else {
setCursor("default");
if (container) {
const value = this.hoveredPoint || this.hoveredGroup ? "pointer" : "default";
container.style.cursor = value;
}
};
}
2 changes: 1 addition & 1 deletion src/core/chart-api/chart-extra-tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export class ChartExtraTooltip extends AsyncStore<ReactiveTooltipState> {
};

private get commonTrackAttrs() {
return { fill: "transparent", zIndex: -1, style: "pointer-events:none", direction: this.direction };
return { fill: "transparent", zIndex: -1, "pointer-events": "none", direction: this.direction };
}

// We compute the direction from the chart container and then explicitly set it to the track
Expand Down
2 changes: 1 addition & 1 deletion src/internal/chart-styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export const navigationFocusOutline = {
export const cursorLine = {
fill: colorChartsLineTick,
zIndex: 5,
style: "pointer-events: none",
"pointer-events": "none",
};

export const focusOutlineOffsets = {
Expand Down
4 changes: 2 additions & 2 deletions src/internal/components/series-marker/render-marker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function getDefaultPointProps(point: Highcharts.Point, selected: boolean, classN
const pointStyle: Highcharts.SVGAttributes = {
zIndex: selected ? 6 : 5,
opacity: 1,
style: "pointer-events: none",
"pointer-events": "none",
class: className,
"stroke-width": 2,
stroke: selected ? colorTextBodyDefault : point.color,
Expand All @@ -92,7 +92,7 @@ function getDefaultPointProps(point: Highcharts.Point, selected: boolean, classN
stroke: point.color,
fill: "transparent",
opacity: 0.4,
style: "pointer-events: none",
"pointer-events": "none",
r: 8,
};
return { size, pointStyle, haloStyle };
Expand Down
Loading