Skip to content

fix: dynamically added columns ignore minWidth#4288

Open
SpyZzey wants to merge 5 commits intomainfrom
fix/resizable-columns-minwidth
Open

fix: dynamically added columns ignore minWidth#4288
SpyZzey wants to merge 5 commits intomainfrom
fix/resizable-columns-minwidth

Conversation

@SpyZzey
Copy link
Member

@SpyZzey SpyZzey commented Feb 24, 2026

Description

Fixes #4236.
Currently, when adding columns to a table with minWidth > DEFAULT_COLUMN_WIDTH, they will still use DEFAULT_COLUMN_WIDTH, even though the minimum width is higher. This PR fixes this issue by checking if minWidth > DEFAULT_COLUMN_WIDTH and if so, setting the width to minWidth.

Related links, issue #, if available: n/a

How has this been tested?

  • Manually tested.
  • Added unit tests.
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.43%. Comparing base (b0bfa53) to head (846f718).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4288   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         897      897           
  Lines       26345    26347    +2     
  Branches     9517     9518    +1     
=======================================
+ Hits        25670    25672    +2     
  Misses        669      669           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SpyZzey SpyZzey marked this pull request as ready for review February 25, 2026 10:41
@SpyZzey SpyZzey requested a review from a team as a code owner February 25, 2026 10:41
@SpyZzey SpyZzey force-pushed the fix/resizable-columns-minwidth branch from 51cc8f0 to 6fe9e53 Compare February 25, 2026 10:41
@SpyZzey SpyZzey requested review from NathanZlion and removed request for a team February 25, 2026 10:41
@SpyZzey SpyZzey force-pushed the fix/resizable-columns-minwidth branch from 6fe9e53 to d5ee2d5 Compare March 3, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: resizableColumns: dynamically added columns ignore minWidth, fall back to DEFAULT_COLUMN_WIDTH

2 participants