Skip to content

fix: Forward data-* attributes to inner button element in copy-to-clipboard #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Who-is-PS wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Forward data-* attributes to inner button element in copy-to-clipboard #4329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/copy-to-clipboard/internal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ export default function InternalCopyToClipboard({
}, [copyErrorText]);

const baseProps = getBaseProps(restProps);

// Extract data-* attributes to forward to the inner button for analytics support.
const dataAttributes: Record<string, string> = {};
Object.keys(restProps).forEach(key => {
if (key.match(/^data-/)) {
dataAttributes[key] = (restProps as Record<string, string>)[key];
}
});
const onClick = () => {
if (!navigator.clipboard) {
// The clipboard API is not available in insecure contexts.
Expand Down Expand Up @@ -87,6 +95,7 @@ export default function InternalCopyToClipboard({

const button = (
<InternalButton
{...dataAttributes}
ariaLabel={copyButtonAriaLabel ?? copyButtonText}
iconName="copy"
variant={triggerVariant}
Expand Down
Loading