Adds Support for TCP Hijack in execStartStream#63
Conversation
clue
left a comment
There was a problem hiding this comment.
@bosunski Thanks for looking into this, I think this is an excellent first step to discuss this feature in mroe detail!
I love the feature, but I'm not sure about the API in its current form.
The execStartStream() currently returns a ReadableStreamInterface (read-only).
It's my understanding the new API that supports writable streams should return a DuplexStreamInterface instead.
The DuplexStreamInterface extends the ReadableStreamInterface, so we could make this the return value of the same function or it might be better to come up with a dedicated API endpoint, I'm currently undecided.
What do you think about this? 👍
|
@clue I'm thinking 🤔 since the I initially added |
clue/reactphp-buzzcomes to play)Summary of changes
$hijakparameter toexectStartsStream$hijakExample Usage