Remove optional $loop constructor argument, always use default loop#156
Merged
SimonFrings merged 1 commit intoclue:3.xfrom Feb 13, 2024
Merged
Remove optional $loop constructor argument, always use default loop#156SimonFrings merged 1 commit intoclue:3.xfrom
$loop constructor argument, always use default loop#156SimonFrings merged 1 commit intoclue:3.xfrom
Conversation
This was referenced Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset removes the optional
$loopconstructor arguments and ensures we always use the default loop. Empirical evidence suggests this should not affect most consumers, as using the default loop is recommended since a couple of years at least (#114). Among others, this is one of the prerequisites for addingawait()-based APIs in a follow-up PR.Builds on top of #149, #129, #114 and others
Refs #118