Support cloning RedisClient instance#172
Merged
PaulRotmann merged 1 commit intoclue:3.xfrom Feb 22, 2025
Merged
Conversation
clue
force-pushed
the
clone
branch
4 times, most recently
from
826afeb to
264cad5
Compare
Owner
Author
|
Rebased to resolve unrelated build error now that #173 is merged |
PaulRotmann
approved these changes
Feb 22, 2025
Collaborator
PaulRotmann
left a comment
PaulRotmann
left a comment
There was a problem hiding this comment.
Now that the tests run, the change LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds support for cloning an existing
RedisClientinstance using theclonekeyword:This can be especially useful if the original connection is used for a PubSub subscription or when using blocking commands or similar and you need a control connection that is not affected by any of this.
The implementation is relatively straight-forward. Major effort went into documenting this feature thoroughly and testing to avoid any unintended side effects. If you enjoy this work, consider supporting this project, for example by becoming a sponsor ❤️
Builds on top of #166, #163, #129 and others
Refs #118