Revert "Update tests to work around segfault on PHP 8.4.4 with Xdebug 3.5.0-dev"#174
Merged
PaulRotmann merged 1 commit intoclue:3.xfrom Mar 6, 2025
Merged
Revert "Update tests to work around segfault on PHP 8.4.4 with Xdebug 3.5.0-dev"#174PaulRotmann merged 1 commit intoclue:3.xfrom
PaulRotmann merged 1 commit intoclue:3.xfrom
Conversation
… 3.5.0-dev" This reverts commit fe2ab07.
PaulRotmann
approved these changes
Mar 6, 2025
Collaborator
PaulRotmann
left a comment
PaulRotmann
left a comment
There was a problem hiding this comment.
Changes in code LGTM. I agree on still reporting this upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset reverts #173 as it no longer appears to be necessary to apply this temporary workaround.
The
shivammathur/setup-php@v2action suggests all builds now use the sameXdebug 3.4.1 enabled as coverage driveracross all supported PHP versions, while previous builds would useXdebug 3.5.0-devon PHP 8.4 only that would cause a segfault. I could not locate a changelog that describes this change unfortunately, but at least it should now work out-of-the-box again.In either case, we may still want to report this upstream to Xdebug and/or shivammathur/setup-php.
Refs #173 and clue/framework-x#276