Draft
Conversation
Author
|
I closed the sockets but it seems thats not enough to fix it with the async changes. Do you have any ideas? |
Owner
New ways to inspect the loop are currently being discussed in https://github.com/orgs/reactphp/discussions/472#discussioncomment-3895536, perhaps you want to join the discussion? As a quick hack, you can add the following dummy test case that would return instantly if the loop has nothing to do, but keep running forever if there are any leftovers from previous tests. You can then move this around in your test suite and check which test cases cause leftovers to help isolate the problem. public function testA()
{
Loop::run();
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close open connections in tests to prevent them from looping in the async update.
Based on reactphp/socket#283 and clue/reactphp-docker#79
Ref: #110