Run tests on PHP 8.4 and update test environment#41
Closed
PaulRotmann wants to merge 1 commit intoclue:1.xfrom
Closed
Run tests on PHP 8.4 and update test environment#41PaulRotmann wants to merge 1 commit intoclue:1.xfrom
PaulRotmann wants to merge 1 commit intoclue:1.xfrom
Conversation
clue
requested changes
Jul 21, 2025
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@PaulRotmann This looks off, can you see what's missing? Hint: it's substantial to the PR :)
Author
|
@clue i see what you were pointing at 😱. Somehow got lost in ensuring compatibility. Now the PR should also fit to the headline. |
Author
|
I got a bit lost here. This PR should be implemented in smaller parts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #37.
For HHVM test suite i oriented on reactphp/socket#299.
Additionally to ensure PHP 5.3 compatibility i had to modify the tests to skip React\Promise\Timer where needed.
This ensures tests run successfully on the latest PHP 8.4 while maintaining backward compatibility with older PHP versions.