reimplement lowest_dword and highest_dword without unsafe blocks#40
reimplement lowest_dword and highest_dword without unsafe blocks#40eduardosm wants to merge 1 commit intocmpute:masterfrom
lowest_dword and highest_dword without unsafe blocks#40Conversation
|
Thanks for the proposal! I'm not sure if this change results in a performance change, I will merge it after I have a better benchmark implementation, and confirmed that this won't result in performance regression. |
|
This is the change (compared to the master branch) measured on my PC: Criterion logsIn summary main regressions come from It will be great if you can provide some benchmark results on your computer. (just run |
388e732 to
aba4e32
Compare
|
I rebased on top of latest master and ran the benchmark (first on master and then on my branch): Criterion logs-40% in ubig_pow/100? I ran it again ubig_pow/100 againSo it looks like it was a huge outlier as a whole... |
|
It seems that the benchmark needs improving... I will try this PR before the next major version release, when I will compare again the performance of |
No description provided.