Skip to content

Add support for admin-only evaluation feedback.#1642

Open
veluca93 wants to merge 1 commit intocms-dev:mainfrom
veluca93:admin-msg
Open

Add support for admin-only evaluation feedback.#1642
veluca93 wants to merge 1 commit intocms-dev:mainfrom
veluca93:admin-msg

Conversation

@veluca93
Copy link
Contributor

@veluca93 veluca93 commented Mar 1, 2026

Admin-only feedback is either automatically generated by the white diff comparison step, or by outputting an additional line on stderr from the checker that starts with ADMIN_MESSAGE:.

@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

❌ Patch coverage is 78.40909% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.71%. Comparing base (fcb1905) to head (0847ea5).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cms/grading/steps/whitediff.py 57.89% 8 Missing ⚠️
cms/grading/tasktypes/util.py 0.00% 5 Missing ⚠️
cms/grading/tasktypes/TwoSteps.py 0.00% 3 Missing ⚠️
cms/grading/steps/trusted.py 90.47% 2 Missing ⚠️
cms/grading/scoretypes/abc.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
+ Coverage   54.67%   54.71%   +0.04%     
==========================================
  Files         335      335              
  Lines       27356    27396      +40     
==========================================
+ Hits        14956    14989      +33     
- Misses      12400    12407       +7     
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 54.71% <78.40%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@prandla prandla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a neat feature, thanks.

imo it'd make more sense to have the admin details be after the public details column though. did you have any reason for having them in this order?

@veluca93
Copy link
Contributor Author

veluca93 commented Mar 2, 2026

looks like a neat feature, thanks.

imo it'd make more sense to have the admin details be after the public details column though. did you have any reason for having them in this order?

No reason :-)

Admin-only feedback is either automatically generated by the white diff
comparison step, or by outputting an additional line on stderr from the
checker that starts with `ADMIN_MESSAGE:`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants