Conversation
✅ Deploy Preview for cncf-techdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
df99150 to
2545994
Compare
chalin
left a comment
There was a problem hiding this comment.
The Docsy links have been fixed. Please undo the changes to the pages under docs, and then rebase your PR or to a merge update. (A rebase would be better.) /cc @nate-double-u
* updating domain and netlify information Signed-off-by: Nate W <natew@cncf.io> * Update docs/services.md Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Nate W <natew@cncf.io> --------- Signed-off-by: Nate W <natew@cncf.io> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
* adding guidance for Series LLCs Signed-off-by: Nate W <natew@cncf.io> * Update docs/website-guidelines-checklist.md Signed-off-by: Nate W <natew@cncf.io> * Update docs/website-guidelines-checklist.md Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Nate W <natew@cncf.io> * updating formatting after applying edit Signed-off-by: Nate W <natew@cncf.io> --------- Signed-off-by: Nate W <natew@cncf.io> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Updating Nate W.'s role. Signed-off-by: Nate W <natew@cncf.io> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
* Revise README, update PC role, add links Signed-off-by: Patrice Chalin <pchalin@gmail.com> * Nate's feedback Signed-off-by: Patrice Chalin <pchalin@gmail.com> --------- Signed-off-by: Patrice Chalin <pchalin@gmail.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
* Add Vitess analysis document. Signed-off-by: Dave Welsch <dwelsch@expertsupport.com> * renaming file Signed-off-by: Nate W <natew@cncf.io> * fixing formatting issues Signed-off-by: Nate W <natew@cncf.io> * fixing formatting issues Signed-off-by: Nate W <natew@cncf.io> * Update per review comments, including recommendations for FAQ and troubleshooting. Signed-off-by: Dave Welsch <dwelsch@expertsupport.com> * Update analyses/0014-vitess/analysis.md Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Nate W <natew@cncf.io> * Update analyses/0014-vitess/analysis.md Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Nate W <natew@cncf.io> * removing SEO, Analytics and local search sections as out of scope for this analyis. Signed-off-by: Nate W <natew@cncf.io> * updating spelling wordlist Signed-off-by: Nate W <natew@cncf.io> * fixing format Signed-off-by: Nate W <natew@cncf.io> * removing markdown disable no-bare-urls Signed-off-by: Nate W <natew@cncf.io> * updating codefence formatting Signed-off-by: Nate W <natew@cncf.io> * disabling fence-code-langage check on quoted content Signed-off-by: Nate W <natew@cncf.io> * fixing formatting Signed-off-by: Nate W <natew@cncf.io> --------- Signed-off-by: Dave Welsch <dwelsch@expertsupport.com> Signed-off-by: Nate W <natew@cncf.io> Co-authored-by: Nate W <natew@cncf.io> Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
…ncf#312) Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
* adding Daniel to staff list Signed-off-by: Nate W <natew@cncf.io> * formatting and spelling Signed-off-by: Nate W <natew@cncf.io> --------- Signed-off-by: Nate W <natew@cncf.io> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Nate W <natew@cncf.io> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Dave Welsch <dwelsch@expertsupport.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: thisisobate <obasiuche62@gmail.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
* Chore: Fix all broken links outlined in issue description Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: format files Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix markdown error Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix markdown error Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix markdown error again Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: fix link checker in CI Signed-off-by: thisisobate <obasiuche62@gmail.com> * chore: add backsticks to link Signed-off-by: thisisobate <obasiuche62@gmail.com> --------- Signed-off-by: thisisobate <obasiuche62@gmail.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <12780597+iRaindrop@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <12780597+iRaindrop@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <12780597+iRaindrop@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <12780597+iRaindrop@users.noreply.github.com> Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Reduce htmltest CacheExpires to ~6 months, update docsy analytics link paths in analytics docs to /docs/content/feedback/#adding-analytics, and refresh static/refcache.json (LastSeen timestamps, some status codes, and a new GitHub ref entry). These changes keep link references current and shorten cache expiry for HTML tests. Signed-off-by: Patrice Chalin Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
d33f662 to
c45e8c9
Compare
Signed-off-by: Bruce Hamilton <scarlettbernique@gmail.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
…nalysis' into bhamilton-flatcar-analysis
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
docs/analytics/index.md
Outdated
| [Adding analytics](https://www.docsy.dev/docs/content/feedback/#adding-analytics) | ||
| [CNCF sandbox]: https://github.com/cncf/sandbox [docsy]: https://www.docsy.dev | ||
| [ga4]: https://support.google.com/analytics/answer/10089681 [service desk]: | ||
| https://github.com/cncf/servicedesk |
There was a problem hiding this comment.
This Markdown is muddled / broken. Besides, as I had suggested before, there should be no changes under docs. That is, revert the changes to this file. This PR should focus exclusively on the flatcar analysis.
There was a problem hiding this comment.
I never had reason to edit index.md and ua-to-ga4.md under docs/analytics, but errors appeared in this PR and I don't know why. Their Markdown is not currently reporting errors now in this PR, so maybe a new PR just to fix them would be good.
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
chalin
left a comment
There was a problem hiding this comment.
LGTM in that all checks are passing an no docs pages are being edited via this PR anymore.
@nate-double-u has agreed to do a final review before this gets merged.
| | Criterion | [Rating (1-5)] | | ||
| | -------------------------- | -------------- | | ||
| | Information architecture | [rating (1-5)] | | ||
| | New user content | [rating (1-5)] | | ||
| | Content maintainability | [rating (1-5)] | | ||
| | Content creation processes | [rating (1-5)] | | ||
| | Inclusive language | [rating (1-5)] | |
There was a problem hiding this comment.
Should the ratings be set for each table-entry row?
There was a problem hiding this comment.
Yes, still to do - thx
|
Would you like me to clean up the commits @iRaindrop (ie, do a rebase)? You'd likely have to check out the PR again if you're working locally on your machine. Let me know. |
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com> Signed-off-by: Nate W <natew@cncf.io>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Signed-off-by: Bruce Hamilton <bhamilton@expertsupport.com>
Added template and started customizing