Fix incorrect instructions in 'Upgrade a Cluster Running PCR'#23151
Fix incorrect instructions in 'Upgrade a Cluster Running PCR'#23151rmloveland wants to merge 2 commits intomainfrom
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
FYI for Docs reviewer - this was LGTM'd in #docs slack channel by @smcvey |
bsanchez-the-roach
left a comment
bsanchez-the-roach
left a comment
There was a problem hiding this comment.
One comment, otherwise LGTM
| {% include_cached copy-clipboard.html %} | ||
| ~~~ sql | ||
| ALTER VIRTUAL CLUSTER <readervc-name> SET REPLICATION READ VIRTUAL CLUSTER; | ||
| ALTER VIRTUAL CLUSTER <application-vc> SET REPLICATION READ VIRTUAL CLUSTER; |
There was a problem hiding this comment.
Is this <application-vc> the same string as <application-vc-readonly>? If so maybe you should just use <application-vc-readonly>? The change in placeholder makes it seem like it should be a different string.
There was a problem hiding this comment.
The change in placeholder makes it seem like it should be a different string.
Yes, it's supposed to be a different string, that is the purpose of this docs change. The first two commands run on the readonly version of the cluster being replicated which is called <cluster>-readonly. The last command rebuilds the readonly version from the non-readonly version so it's <cluster> without the -readonly.
There was a problem hiding this comment.
I see, makes sense. @rmloveland Possible suggestion of using <application-vc-main> to differentiate? I wasn't sure which VC (of the two mentioned in step 4) that that placeholder referred to. But up to you, might be obvious to someone who knows more about the topic.
3 participants
Fixes DOC-16558