Support for Multiple Domain names (instance behind reverse proxy)#2256
Open
Support for Multiple Domain names (instance behind reverse proxy)#2256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A brief description of the purpose of the changes contained in this PR.
If the instance is deployed behind a reverse proxy, which then proxies the requests via HTTPS, there can be some errors related to CSRF which are fixed in this PR.
If the DOMAIN_NAME is not the same as the external domain name for the website, some things like emails will use an unknown domain name as the URL, this PR fixes this.
To fix these problems, use the new
EXTERNAL_DOMAIN_NAMEvariable in the .env, setting it to the domain name that is available externally while keeping theDOMAIN_NAMElocally accessible.Checklist