fix(utils): add silent flag to executeProcess#1144
Conversation
|
View your CI Pipeline Execution ↗ for commit 75993eb
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 1ef1c5b with previous commit c90eea2. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 4 audits regressed, 14 audits changed without impacting score🗃️ Groups
21 other groups are unchanged. 🛡️ Audits
659 other audits are unchanged. |
|
Hi, you've run into a bug I discovered recently. The plugins are supposed to be run sequentially. I designed the logger groups and spinners based on this assumption, then I found out that it was (probably mistakenly) refactored to concurrent execution some time ago. 😅 I've opened a PR to prevent concurrent execution. This should enable the Axe plugin to log processes just like any other plugin. The problem isn't specific to Axe, any 2 plugins that execute some shell command would run into the same conflict. |
|
Closing this PR in favor of the fix that restores sequential plugin execution. |
Problem
The Axe plugin failed during its first test run in an external repository:
Root cause: The logger only supports one spinner at a time. When plugins execute concurrently, the Axe plugin's browser installation attempts to start a second spinner while another plugin's spinner is active, triggering the error.
Solution
Added a
silentflag toexecuteProcessto bypass the logger spinner for background operations:Testing
executeProcesssource code