refactor: simplify trace types and helper #1236

BioPhoton · 2026-02-03T15:59:14Z

Implement performance profiling and trace file generation #1197

This PR includes:

simper tract event types
fixed detail structure
renamed helper
added unique id helper

Followup:

refactor: refactor sharded wal to handle coordinator #1237

nx-cloud · 2026-02-03T16:00:49Z

View your CI Pipeline Execution ↗ for commit 058c9c1

Command	Status	Duration	Result
`nx run-many -t unit-test,int-test`	✅ Succeeded	2m	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-03 22:14:18 UTC

nx-cloud · 2026-02-03T16:00:49Z

View your CI Pipeline Execution ↗ for commit ad83c42

Command	Status	Duration	Result
`nx run ci:code-pushup -- merge-diffs --files=/h...`	✅ Succeeded	6s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	1m 33s	View ↗
`nx run-many --targets=code-pushup --parallel=fa...`	✅ Succeeded	13m 39s	View ↗
`nx run-many -t unit-test,int-test`	✅ Succeeded	1m 16s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-03 16:16:42 UTC

pkg-pr-new · 2026-02-03T16:01:03Z

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1236

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1236

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1236

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1236

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1236

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1236

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1236

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1236

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1236

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1236

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1236

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1236

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1236

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1236

commit: 058c9c1

github-actions · 2026-02-03T16:10:05Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 341273e with previous commit 7b6e72c.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Performance	🔴 33	🔴 37
Documentation	🟡 53	🟡 53
Code coverage	🟢 93	🟢 93
Bug prevention	🟡 75	🟡 75
Axe Accessibility	🟡 88	🟡 88
Code style	🟢 100	🟢 100	–
Security	🔴 47	🔴 47	–
Updates	🟡 78	🟡 78	–
Type Safety	🟡 67	🟡 67	–
Miscellaneous	🟡 67	🟡 67	–
Accessibility	🟢 92	🟢 92	–
Best Practices	🟢 100	🟢 100	–
SEO	🟢 92	🟢 92	–

👍 1 group improved, 👎 2 groups regressed, 👍 5 audits improved, 👎 5 audits regressed, 18 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score
Lighthouse	Performance	🔴 33	🔴 37
JSDocs coverage	Documentation coverage	🟡 53	🟡 53
Code coverage	Code coverage metrics	🟢 93	🟢 93

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Lighthouse	Minify CSS	🟩 0	🟨 Potential savings of 10 KiB
Lighthouse	Total Blocking Time	🟥 3,150 ms	🟥 1,560 ms
Lighthouse	Speed Index	🟥 7.3 s	🟥 6.8 s
JSDocs coverage	Types coverage	🟥 264 undocumented types	🟥 264 undocumented types
Lighthouse	Time to Interactive	🟥 14.2 s	🟥 13.1 s
JSDocs coverage	Variables coverage	🟥 274 undocumented variables	🟥 273 undocumented variables
Lighthouse	First Contentful Paint	🟥 3.1 s	🟥 3.0 s
JSDocs coverage	Functions coverage	🟥 585 undocumented functions	🟥 585 undocumented functions
JSDocs coverage	Properties coverage	🟥 42 undocumented properties	🟥 43 undocumented properties
Code coverage	Branch coverage	🟨 89.2 %	🟨 89.1 %
Lighthouse	Avoids enormous network payloads	🟩 Total size was 2,087 KiB	🟩 Total size was 2,113 KiB
Lighthouse	Minimizes main-thread work	🟥 13.9 s	🟥 9.6 s
Lighthouse	JavaScript execution time	🟥 4.6 s	🟥 3.1 s
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	Uses efficient cache policy on static assets	🟨 31 resources found	🟨 31 resources found
Lighthouse	Server Backend Latencies	🟩 640 ms	🟩 850 ms
Lighthouse	Max Potential First Input Delay	🟥 1,190 ms	🟥 1,040 ms
Lighthouse	Reduce unused JavaScript	🟥 Potential savings of 225 KiB	🟥 Potential savings of 225 KiB
Lighthouse	Remove duplicate modules in JavaScript bundles	🟥 Potential savings of 86 KiB	🟥 Potential savings of 93 KiB
Lighthouse	Largest Contentful Paint	🟥 11.7 s	🟥 11.7 s
Lighthouse	Initial server response time was short	🟥 Root document took 620 ms	🟥 Root document took 610 ms
Lighthouse	Reduce unused CSS	🟥 Potential savings of 125 KiB	🟥 Potential savings of 146 KiB
TypeScript	Semantic errors	🟥 43 errors	🟥 36 errors
JS packages	Outdated npm prod dependencies.	🟨 19 outdated package versions (5 major, 11 minor, 3 patch)	🟨 21 outdated package versions (5 major, 12 minor, 4 patch)
Lighthouse	ARIA `tooltip` elements have accessible names	🟩 passed	🟩 0
Axe	ARIA hidden element must not be focusable or contain focusable elements	🟩 201 elements	🟩 202 elements
Lighthouse	Network Round Trip Times	🟩 10 ms	🟩 10 ms
Code coverage	Line coverage	🟩 92.8 %	🟩 92.8 %

651 other audits are unchanged.

github-actions · 2026-02-03T16:16:13Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 341273e with previous commit 7b6e72c.

💼 Project `utils`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Documentation	🟡 61	🟡 60
Code coverage	🟢 95	🟢 95

4 other categories are unchanged.

👎 2 groups regressed, 👍 2 audits improved, 👎 4 audits regressed

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
JSDocs coverage	Documentation coverage	🟡 61	🟡 60
Code coverage	Code coverage metrics	🟢 95	🟢 95

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
JSDocs coverage	Variables coverage	🟥 50 undocumented variables	🟥 49 undocumented variables
JSDocs coverage	Types coverage	🟨 55 undocumented types	🟨 55 undocumented types
JSDocs coverage	Functions coverage	🟥 243 undocumented functions	🟥 243 undocumented functions
JSDocs coverage	Properties coverage	🟥 39 undocumented properties	🟥 40 undocumented properties
Code coverage	Branch coverage	🟩 91.9 %	🟩 91.8 %
Code coverage	Line coverage	🟩 97.8 %	🟩 97.8 %

438 other audits are unchanged.

13 other projects are unchanged.

packages/utils/src/lib/profiler/trace-file-utils.ts

packages/utils/src/lib/process-id.ts

packages/utils/src/lib/profiler/trace-file-utils.ts

packages/utils/src/lib/process-id.ts

packages/utils/src/lib/process-id.unit.test.ts

hanna-skryl · 2026-02-03T19:19:57Z

packages/utils/src/lib/profiler/trace-file-utils.unit.test.ts

+    const result = serializeTraceEvent(event);

-    expect(result).toStrictEqual({
+    expect(typeof result).toBe('string');


I'd recommend using either Vitest's .toBeTypeOf('string') or jest-extended's .toBeString() instead. This also applies in other places in this PR.

Suggested change

expect(typeof result).toBe('string');

expect(result).toBeString();

Also, is this check really necessary (here and everywhere else)? If the toStrictEqual below passes, the produced result is correct, isn't it?

There are still seven instances of a check similar to expect(typeof result).toBe('string');.

packages/utils/src/lib/process-id.unit.test.ts

packages/utils/src/lib/profiler/trace-file-utils.unit.test.ts

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

hanna-skryl · 2026-02-04T17:06:58Z

packages/utils/src/lib/profiler/trace-file-utils.ts

  metadata?: Partial<TraceMetadata>;
 }): TraceEventContainer => ({
-  traceEvents: opt.traceEvents,
+  traceEvents: opt.traceEvents.map(encodeEvent),


createTraceFile now encodes events internally, but generateTraceContent, where it's used, immediately discards those encoded events by overwriting traceEvents 🤔

hanna-skryl · 2026-02-04T17:10:36Z

packages/utils/src/lib/wal.unit.test.ts

  it('should handle zero values', () => {
-    const result = getShardId();
+    const counter = { next: () => 1 };
+    const result = getUniqueInstanceId(counter);
    expect(result).toStartWith('20231114-221320-000.');
  });

  it('should handle negative timestamps', () => {
-    const result = getShardId();
+    const counter = { next: () => 1 };
+    const result = getUniqueInstanceId(counter);

    expect(result).toStartWith('20231114-221320-000.');
  });

  it('should handle large timestamps', () => {
-    const result = getShardId();
+    const counter = { next: () => 1 };
+    const result = getUniqueInstanceId(counter);

    expect(result).toStartWith('20231114-221320-000.');
  });


The content of these tests is identical, but their descriptions differ. Is there something implied I'm missing?

hanna-skryl · 2026-02-04T17:12:39Z

packages/utils/src/lib/process-id.unit.test.ts

+  );
+});
+
+describe('ID_PATTERNS', () => {


There are three it.each() test cases in the ID_PATTERNS suite with only one input. Is this necessary?

refactor: simplify trace types and helper

ad83c42

github-actions bot assigned BioPhoton Feb 3, 2026

github-actions bot added 🔬 testing writing tests 🧩 utils labels Feb 3, 2026

BioPhoton marked this pull request as ready for review February 3, 2026 16:18

refactor: wip

04ac4c3

BioPhoton requested a review from hanna-skryl February 3, 2026 18:22

This was referenced Feb 3, 2026

refactor: refactor sharded wal to handle coordinator #1237

Draft

Implement performance profiling and trace file generation #1197

Open

hanna-skryl reviewed Feb 3, 2026

View reviewed changes

BioPhoton and others added 9 commits February 3, 2026 21:48

Update packages/utils/src/lib/profiler/trace-file-utils.unit.test.ts

36d74f8

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

Update packages/utils/src/lib/process-id.unit.test.ts

7193a57

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

Update packages/utils/src/lib/process-id.unit.test.ts

78d76d2

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

Update packages/utils/src/lib/profiler/trace-file-utils.unit.test.ts

c972833

Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>

refactor: remove redundant code

3f150db

refactor: fix incorrect instant event "ph" value

72e8baa

refactor: wip

5396322

refactor: wip

ef8f513

refactor: wip

058c9c1

BioPhoton requested a review from hanna-skryl February 3, 2026 21:47

BioPhoton enabled auto-merge (squash) February 3, 2026 22:11

hanna-skryl reviewed Feb 4, 2026

View reviewed changes

	expect(typeof result).toBe('string');
	expect(result).toBeString();

refactor: simplify trace types and helper #1236

Are you sure you want to change the base?

refactor: simplify trace types and helper #1236

Uh oh!

Conversation

BioPhoton commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

🏷️ Categories

🗃️ Groups

🛡️ Audits

Uh oh!

github-actions bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

💼 Project utils

🗃️ Groups

🛡️ Audits

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hanna-skryl Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

hanna-skryl Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

hanna-skryl Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hanna-skryl Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

hanna-skryl Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

hanna-skryl Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BioPhoton commented Feb 3, 2026 •

edited

Loading

nx-cloud bot commented Feb 3, 2026 •

edited

Loading

nx-cloud bot commented Feb 3, 2026 •

edited

Loading

pkg-pr-new bot commented Feb 3, 2026 •

edited

Loading

github-actions bot commented Feb 3, 2026 •

edited

Loading

github-actions bot commented Feb 3, 2026 •

edited

Loading

💼 Project `utils`