Skip to content

Fix duplicate artifact downloads (again)#176

Merged
matejchalk merged 1 commit intomainfrom
fix-artifacts-cache
May 2, 2025
Merged

Fix duplicate artifact downloads (again)#176
matejchalk merged 1 commit intomainfrom
fix-artifacts-cache

Conversation

@matejchalk
Copy link
Contributor

@matejchalk matejchalk commented May 2, 2025

Missed an important detail in #174 😅 Artifacts are downloaded in parallel, so the promises have to be cached, the resolved values won't be available yet 🤦‍♂️

@matejchalk matejchalk added the bug Something isn't working label May 2, 2025
@matejchalk matejchalk self-assigned this May 2, 2025
@matejchalk matejchalk requested a review from vmasek May 2, 2025 13:03
@github-actions
Copy link

github-actions bot commented May 2, 2025

Code PushUp

🥳 Code PushUp report has improved – compared current commit d6cd05e with previous commit 0ce6883.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 58 🟡 59 ↑ +0.3
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Security 🔴 49 🔴 49
Updates 🟢 97 🟢 97
👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 58 🟡 59 ↑ +0.3

11 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟥 37 % 🟥 38 % ↑ +2.5 %
Code coverage Line coverage 🟨 57.2 % 🟨 57.5 % ↑ +0.4 %

170 other audits are unchanged.

@matejchalk matejchalk merged commit 2fc66b7 into main May 2, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants