[pull] master from rustdesk:master#417
Merged
pull[bot] merged 2 commits intocode:masterfrom Feb 19, 2026
Merged
Conversation
…14354) Terminal tab keys use the format "peerId_terminalId". The previous code used split('_')[0] or startsWith('$peerId_') to extract the peerId, which breaks when the peerId itself contains underscores. This can happen in two scenarios: - Hostname-based ID: when OPTION_ALLOW_HOSTNAME_AS_ID is enabled, the peerId is derived from the system hostname, which commonly contains underscores (e.g. "my_dev_machine"). - Custom ID: the validation regex ^[a-zA-Z][\w-]{5,15}$ allows underscores since \w matches [a-zA-Z0-9_], so IDs like "my_dev_01" are valid. Fix all three parsing sites in terminal_tab_page.dart to use lastIndexOf('_'), which is safe because terminalId is always a plain integer with no underscores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )