Skip to content

[pull] master from apache:master #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Feb 19, 2026
Merged

[pull] master from apache:master #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTableChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,13 @@ export default function TableChart<D extends DataRecord = DataRecord>(
);

const timestampFormatter = useCallback(
value => getTimeFormatterForGranularity(timeGrain)(value),
[timeGrain],
(value: DataRecordValue) =>
isRawRecords
? String(value ?? '')
: getTimeFormatterForGranularity(timeGrain)(
value as number | Date | null | undefined,
),
[timeGrain, isRawRecords],
);

const toggleFilter = useCallback(
Expand All @@ -276,7 +281,14 @@ export default function TableChart<D extends DataRecord = DataRecord>(
setDataMask(getCrossFilterDataMask(crossFilterProps).dataMask);
}
},
[emitCrossFilters, setDataMask, filters, timeGrain],
[
emitCrossFilters,
setDataMask,
filters,
timeGrain,
isActiveFilterValue,
timestampFormatter,
],
);

const handleServerPaginationChange = useCallback(
Expand Down
3 changes: 2 additions & 1 deletion superset-frontend/plugins/plugin-chart-ag-grid-table/src/transformProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ const processColumns = memoizeOne(function processColumns(
metrics: metrics_,
percent_metrics: percentMetrics_,
column_config: columnConfig = {},
query_mode: queryMode,
},
queriesData,
} = props;
Expand Down Expand Up @@ -393,7 +394,7 @@ const processColumns = memoizeOne(function processColumns(
const timeFormat = customFormat || tableTimestampFormat;
// When format is "Adaptive Formatting" (smart_date)
if (timeFormat === SMART_DATE_ID) {
if (granularity) {
if (granularity && queryMode !== QueryMode.Raw) {
// time column use formats based on granularity
formatter = getTimeFormatterForGranularity(granularity);
} else if (customFormat) {
Expand Down
Loading
Loading