Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… areas When an edit (delete/undo) removes or merges the only visible line(s) into hidden lines, the view model could end up with zero visible lines, causing downstream crashes (e.g. 'Not supported' from HiddenModelLineProjection). The safety check in acceptVersionId only caught the case where exactly 1 hidden line remained. Generalize it to detect when getViewLineCount() === 0 and minimally restore visibility by making just the first line visible, preserving the caller's intended hidden areas as much as possible.
…ible lines) is now fixed at the source
When hidden area decorations drift via AlwaysGrowsWhenTypingAtEdges stickiness, _constructLines(resetHiddenAreas=false) — triggered by tab size or wrapping changes — can rebuild projections with all lines hidden. Extract _ensureAtLeastOneVisibleLine() shared by both _constructLines and acceptVersionId.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
GitService - more tweaks
* add logging * feedback
Fix ViewModel issue where all lines were hidden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )