Conversation
* perf: switch to clack spinner This is an incremental change as part of the wider move to clack. * perf: switch to clack for box rendering Switches to using clack for rendering boxes in the terminal. Part of the wider migration to clack. * perf: switch to clack for confirm prompts Switches to using clack for confirm prompts rather than `prompts` package. Part of the wider clack migration. * chore: use new spinner API * chore: use bold confirm messages * fix * fix * upgrade clack * update clack * improve * improve * changeset --------- Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This is similar to #15516 but refactors tests around responses to various scenarios, such as trailing slash behavior.
These test various scenarios where `Astro.locals` is used, such as when passed down from an adapter. Converted to unit tests and removed the fixture.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Refactor error page rendering tests to unit tests This took ssr-error-pages.test.js which was testing how we handle error pages, like for example rendering the 404.astro route when the page route returned a 400, and then converted those to error tests. Note that the tests are a little verbose at present. Further refactors, especially around routing, will make these smaller. * Fix lint * Update packages/astro/test/units/app/error-pages.test.js Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev> --------- Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
* fix(content): reload markdown updates in dev * fix lint + comment * test: fix hmr markdown fixture
* feat: improve naming of new adapter api * chore: changesets * Apply suggestions from code review * fix * Update .changeset/light-parrots-find.md * feat: warning * Apply suggestions from code review * Apply suggestion from @florian-lefebvre * Update packages/astro/src/types/public/integrations.ts * Update packages/astro/src/types/public/integrations.ts * Update .changeset/light-parrots-find.md * Apply suggestions from code review Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com> * Update .changeset/bright-symbols-see.md Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com> * Update .changeset/bright-symbols-see.md Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com> --------- Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )