Conversation
# Why closes #34523 This PR fixes an issue with notification handling on Android by properly filtering out OEM-injected extras that aren't actual FCM notifications. Some device manufacturers (like Samsung) inject extras into intents that can be mistakenly processed as notifications. # How - Added a constant `GOOGLE_MESSAGE_ID_KEY` to reference the FCM message ID key consistently - Added validation in `ExpoNotificationLifecycleListener` to check if intents contain the FCM message ID before processing them as notifications # Test Plan - notification tester app on device - send push notification to a killed app, tap it, observe `isFCMIntent` returning `true` in `ExpoNotificationLifecycleListener` # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why This PR optimizes GitHub Actions workflows by excluding test files and documentation from triggering CI runs. By adding path exclusions for markdown files (`!**.md`), test directories (`!**/__tests__/**`), and mock directories (`!**/__mocks__/**`), we prevent unnecessary workflow executions when only documentation or tests are modified. # How Added path exclusions to multiple GitHub Actions workflow files: - `android-instrumentation-tests.yml` - `brownfield.yml` - `test-suite-brownfield-isolated.yml` - `test-suite-brownfield.yml` - `test-suite-macos.yml` - `test-suite.yml` For the main `test-suite.yml`, also replaced the broad `packages/**` path with specific package paths that have e2e tests, making the workflow more targeted. # Test Plan # Checklist - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Wiktor Smaga <wiktor.smaga13@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )