Conversation
* fix: fixed to be more properly timing safe Co-authored-by: Taku Amano <taku@taaas.jp> * format * Remove comparing `a` and `b` I think this is necessary. * Remove `console.warn` It is annoying for users. I think only adding the `@deprecated` comment is okay. * update the test * test: add a test for well-known md5 hash collision Co-authored-by: Taku Amano <taku@taaas.jp> * Revert "Remove comparing `a` and `b`" This reverts commit 77b86fd6f7b9f8746dde0933b69eda922e96d0de. * remove the unused file --------- Co-authored-by: Taku Amano <taku@taaas.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )