[pull] canary from vercel:canary#809
Merged
pull[bot] merged 8 commits intocode:canaryfrom Feb 20, 2026
Merged
Conversation
…following best practices (#87069) ## What? Modernizes the existing `with-docker` example and adds a new `with-docker-export-output` example demonstrating different Next.js deployment strategies with Docker best practices: 1. **`with-docker` (updated)** - Modernized to use App Router, TypeScript, Tailwind CSS v4, and comprehensive Docker best practices. Now includes both Node.js and Bun Dockerfile options, Docker Compose with profiles, BuildKit cache mounts, and extensive documentation. 2. **`with-docker-export-output` (new)** - Demonstrates Next.js static export mode deployment with Docker, offering two serving options: **Nginx** (production-grade) and **serve** package (Node.js-based, simpler setup). Includes optimized Nginx configuration, BuildKit cache mounts, and comprehensive documentation. Both examples include detailed documentation explaining Docker best practices, implementation decisions, and deployment guidance. ## Why? The existing `with-docker` example was using the Pages Router and lacked: - Modern Next.js patterns (App Router, TypeScript) - Detailed documentation explaining Docker best practices and implementation decisions - BuildKit cache mounts for optimized build performance - Bun runtime support as an alternative to Node.js - Docker Compose configurations for easier local development - Clear documentation about Node.js image variant choices (slim vs Alpine) - Examples demonstrating static export mode These updates serve as comprehensive references for developers who want to understand: - How to Dockerize Next.js applications for different deployment scenarios - Why certain choices are made and how to optimize Docker setups for production - When to use standalone mode vs static export mode - How to choose between Node.js and Bun runtimes - How to choose between different web servers (Nginx vs serve) for static sites ## How? ### `with-docker` example (updated) - **Migrated to App Router** with TypeScript and Tailwind CSS v4 - **Multi-stage Dockerfile** with three stages: dependencies installation, build, and runtime - **Bun support** via `Dockerfile.bun` with optimized configuration - **BuildKit cache mounts** for package manager stores (`npm`, `yarn`, `pnpm`, `bun`) and Next.js build cache - **Security best practices** with non-root user execution (built-in `node` and `bun` users) - **Docker Compose configuration** with profiles for Node.js (default) and Bun - **Comprehensive `.dockerignore`** to minimize build context size - **Detailed README** explaining standalone mode benefits, Node.js image choices, and deployment guidance - **Deleted** `with-docker-standalone-output` (merged into this example) ### `with-docker-export-output` example (new) - **Two Dockerfile options:** - `Dockerfile` - Nginx-based serving with `nginxinc/nginx-unprivileged` for security - `Dockerfile.serve` - Node.js serve package-based serving for simpler deployments - **Multi-stage builds** for both options with separate dependency, build, and runtime stages - **BuildKit cache mounts** for package manager stores and Next.js build cache - **Production Nginx configuration** (`nginx.conf`) with gzip compression, caching headers, and security best practices - **Docker Compose configuration** supporting both serving options via profiles - **Comprehensive README** explaining static export mode, trade-offs between Nginx and serve ### Docker best practices implemented (both examples) | Practice | Description | |----------|-------------| | Multi-stage builds | Optimal image size reduction | | Layer caching | Package files copied first | | Minimal build context | Comprehensive `.dockerignore` files | | BuildKit cache mounts | Faster subsequent builds | | Security hardening | Non-root user execution | | Corepack | yarn/pnpm version management | | Package manager auto-detection | npm, yarn, pnpm support | | Node.js 24.13.0-slim | Clear upgrade guidance | ## Breaking Changes > **Warning** > - `with-docker` now uses App Router instead of Pages Router > - `with-docker-standalone-output` has been removed (merged into `with-docker`) --- **Note:** After this PR is approved and merged, I plan to open a follow-up PR to update the Next.js documentation with proper links to these Docker examples. --------- Co-authored-by: Wyatt Johnson <accounts+github@wyattjoh.ca> Co-authored-by: Joseph <joseph.chamochumbi@vercel.com> Co-authored-by: kristiyan.velkov <kristiyan.velkov@ffw.com>
#90215) `workStore` is a request-scoped value available via `workAsyncStorage.getStore()` anywhere during rendering. Threading it as an explicit parameter was originally done to enforce that these functions are only callable within a valid work scope, but we already throw InvariantErrors when the store is missing in many other places. Reading it from async storage is more idiomatic and removes a parameter that every caller had to forward without ever varying. This is a step toward making metadata components renderable directly without a factory closure that captures workStore.
Stacked on #90215 workStore was threaded through 6 functions in resolve-metadata.ts and the entire createMetadataComponents closure but only used once for workStore.route in accumulateMetadata. It now reads from workAsyncStorage.getStore() at that single usage site instead. This eliminates workStore from the createMetadataComponents parameter list entirely, bringing it one step closer to being replaceable with plain components.
We forgot to export a type for the `unstable_instant` config. This works
now
```tsx
import type { Instant } from 'next'
export const unstable_instant: Instant = { ... }
```
… metadata (#90249) Stacked on #90217 Metadata resolution only needs param names and values to pass to generateMetadata. It doesn't need treeSegment, staticSiblings, or the DynamicParam type that getDynamicParamFromSegment produces. Replace the closure dependency with interpolatedParams (a plain Params object) and use getSegmentParam to parse segment names inline. This replaces a closure over request-scoped state with a simple data value, removing another dependency that blocked making metadata components standalone.
Adds an "Instant Navigation Mode" toggle to the Dev Tools indicator menu. When enabled, navigations only show the cached/prefetched state — the same behavior as the instant navigation testing API, but toggled from the dev tools UI instead of test code. Gated behind `experimental.instantNavigationDevToolsToggle`. This is a proof of concept — the UX needs more work before it's ready to ship broadly (e.g. the toggle should be more discoverable, and the locked state needs clearer visual feedback). But it's sufficient to demonstrate the workflow and get feedback. https://github.com/user-attachments/assets/ce2992e1-2794-43d6-baef-d10750d8d8e8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )