[pull] main from remotion-dev:main#712
Merged
Conversation
- Convert `out-dir`, `package-manager` to `AnyRemotionOption` with `getValue()`/`setConfig()`, register in options index, and wire up Config setters and docs (`<Options id="..." />`). - In lambda render.ts, destructure `audioCodecOption`/`videoCodecOption` from `BrowserSafeApis.options` and use `.getValue()` instead of reading `parsedCli[...cliFlag]` directly. Co-authored-by: Cursor <cursoragent@cursor.com>
…-client-side-rendering, image-sequence-pattern to RemotionOption pattern - Create webpackPollOption with getValue()/setConfig(), replacing the imperative setWebpackPollingInMilliseconds in parseCommandLine(). - Update parse-command-line.ts types to use option cliFlag references for all 4 flags. - Update parsed-cli.ts boolean flags for keyboard-shortcuts and experimental-client-side-rendering. - Update studio.ts to use webpackPollOption.getValue() instead of ConfigInternals.getWebpackPolling(). - Replace hardcoded descriptions in docs with <Options id="..." />. Co-authored-by: Cursor <cursoragent@cursor.com>
…bundle-cache, env-file to RemotionOption pattern New option definitions for: stillFrameOption, imageSequenceOption, versionFlagOption, bundleCacheOption, envFileOption. Existing options (scaleOption, overwriteOption, crfOption, logLevelOption, videoCodecOption) get their CommandLineOptions types updated to use the option's cliFlag. - Remove imperative bundle-cache/frame/sequence handling from parseCommandLine(); consumers now use getValue() directly. - Update get-cli-options.ts, get-env.ts, setup-cache.ts, and lambda/cloudrun sites/create.ts to read via option getValue(). - Replace hardcoded descriptions in docs with <Options id="..." />. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
minimist now properly handles --bundle-cache, --no-bundle-cache, and absence of the flag (null) so getValue can distinguish "not passed" from "explicitly false". Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ptions Move concurrency validation into concurrencyOption.getValue(). All callers now get these values directly via option.getValue() instead of through getCliOptions. Also fix cloudrun still.ts which was passing isStill: false instead of isStill: true. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…otion-dev/remotion into migrate-cli-flags-to-options
The validate-concurrency.ts import pulls in node:child_process via get-cpu-count.ts, breaking webpack bundling. Replace with an inline browser-safe validator that performs the same type/format checks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
`@remotion/cli`: Migrate hardcoded CLI flags to proper RemotionOption definitions
…ons system Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ns-2 `@remotion/cli`: Migrate runs, gl, repro, and muted CLI flags to options system
…e packages Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
`@remotion/cli`: Move lambda/cloudrun-only flags to respective packages and add no-open option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )