Extend Rubocop #2452
Merged
Extend Rubocop #2452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a few more extensions
olleolleolle
reviewed
Feb 1, 2026
Comment on lines
-13
to
17
| if workshop_sponsors.save | ||
| flash[:notice] = 'Sponsor added successfully' | ||
| flash[:notice] = if workshop_sponsors.save | ||
| 'Sponsor added successfully' | ||
| else | ||
| flash[:notice] = workshop_sponsors.errors.full_messages.to_s | ||
| workshop_sponsors.errors.full_messages.to_s | ||
| end |
Collaborator
There was a problem hiding this comment.
A style I've been using, to get balanced if/else/end blocks, is:
foo =
if true
# code here
else
# and here
end
Contributor
Author
There was a problem hiding this comment.
I like it, if you feel strongly about it we can see if Rubocop supports its enforcement.
olleolleolle
approved these changes
Feb 1, 2026
Collaborator
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
Nice, focused changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading an article about
standardrband realised we have Rubocop installed but we don’t use it a lot. I looked a bit more into it, added a few plugins, and I’m planning to bringovercommitinto the project to trigger these checks automatically (happy to talk about this, we could do it differently, like through a GitHub action).The second commit was Rubocop fixing the simple instances, so there are still many infringement but they are not safe replacements, so they’ll need human intervention (in other words, more to come).