-
-
Notifications
You must be signed in to change notification settings - Fork 198
Replace Selenium with Playwright for JavaScript tests #2458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Anecdotal benchmarks from running BeforeIntermittent failures AfterNo failures |
- Document complete design for migrating from Selenium to Playwright - Include technical approach, validation plan, and cost-benefit analysis - Add development workflow section to CLAUDE.md specifying PR-only changes
13 task implementation plan with step-by-step instructions: - Dependency updates - Configuration changes - Docker and CI integration - Test validation - Documentation updates
Switch to Playwright for JavaScript browser automation. Provides better debugging tools and improved test stability.
Replace Selenium Chrome driver with Playwright. Supports chromium (default), firefox, and webkit browsers. Headless by default, override with PLAYWRIGHT_HEADLESS=false.
Update test code to work with Playwright driver: - Fix select_from_chosen helper to use JavaScript API instead of native send_keys (Playwright ElementHandle incompatibility) - Update admin members test: change expected subscription count from 0 to -1 (subscription is correctly deleted) - Update manage workshop attendances test: use select_from_chosen helper for Chosen.js dropdown - Replace Selenium window switching with Capybara window_opened_by and within_window for cross-window navigation All 6 JavaScript tests now pass with Playwright driver.
Add Playwright browser installation to Dockerfile. Ensures JavaScript tests work in Docker environment.
Add Playwright installation to bin/dup for initial setup. Ensures new developers have browsers installed.
Add Playwright browser installation to GitHub Actions: - Cache browsers at ~/.cache/ms-playwright (~100MB) - Install browsers and deps on cache miss - Only install system deps on cache hit - Set PLAYWRIGHT_HEADLESS=true for CI runs
Document Playwright as JavaScript driver. Add instructions for debugging and cross-browser testing.
96710f1 to
8e70c0c
Compare
olleolleolle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Playwright! This is the best Capybara Driver I've used, yet.
If you want to keep the Claude plans docs for this implementation, I'm not going to stop you, but it'd be good to learn some reasons for keeping it in the repo. I don't know much about what that does to other usage of Claude.
Summary
Migrates from Selenium to Playwright for JavaScript browser automation in feature specs.
Changes
selenium-webdriverwithcapybara-playwright-drivergemBenefits
Testing
Developer Impact
PLAYWRIGHT_HEADLESS=falsefor visible debuggingPWDEBUG=1for Playwright Inspectorbin/drspeccontinues to work as before