Added recursive file set resolving for the WebAppFileSetResolver#8
Open
penguinboy wants to merge 4 commits intocodedance:masterfrom
penguinboy:recursive_webbappfilesetresolver
Open
Added recursive file set resolving for the WebAppFileSetResolver#8penguinboy wants to merge 4 commits intocodedance:masterfrom penguinboy:recursive_webbappfilesetresolver
penguinboy wants to merge 4 commits intocodedance:masterfrom
penguinboy:recursive_webbappfilesetresolver
Conversation
This reverts commit b868fcd.
…mplate model. In the case of a null model this would result in a crash. Additionally, model values would be overwritten by the runtime globals.
Conflicts: src/main/java/com/papercut/silken/SilkenServlet.java src/main/java/com/papercut/silken/Utils.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files in subdirectories of top-level namespaces are now added as a part of that namespace.
For example, we have a namespace directory like this:
We used to only resolve the namespace as the single file
foo.soy.With the attached changed both
foo.soyandbar.soywill be included.