Skip to content

⚡️ Speed up function pytest_cmd_tokens by 125% in PR #1887 (codeflash_python) #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: codeflash_python
Choose a base branch
from
+15 −1
Open

⚡️ Speed up function pytest_cmd_tokens by 125% in PR #1887 (codeflash_python) #1895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion codeflash/verification/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
import threading
from collections.abc import Sequence

_SHLEX_SPECIAL = set(" \t\n\r\x0b\x0c'\"\\#")

logger = logging.getLogger(__name__)

_TIMING_MARKER_PATTERN = re.compile(r"!######.+:(\d+)######!")
Expand All @@ -34,7 +36,19 @@ def setup_pytest_cmd(pytest_cmd: str | None) -> None:
def pytest_cmd_tokens(is_posix: bool) -> list[str]:
import shlex

return shlex.split(PYTEST_CMD, posix=is_posix)
cmd: str = PYTEST_CMD

# Fast-paths:
# - empty string -> [] (same as shlex.split)
# - single simple token with no whitespace or shlex-special characters -> [cmd]
if not cmd:
return []
# If none of the special characters are present, shlex.split would yield a single
# token identical to cmd (and raise no parsing errors), so return it directly.
for ch in cmd:
if ch in _SHLEX_SPECIAL:
return shlex.split(cmd, posix=is_posix)
return [cmd]


def build_pytest_cmd(safe_sys_executable: str, is_posix: bool) -> list[str]:
Expand Down
Loading