Skip to content

fix: use cross-context type detection in V8 serializer self-test #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohammedahmed18 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use cross-context type detection in V8 serializer self-test #1899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions packages/codeflash/runtime/serializer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,18 @@ try {
// Verify serialize/deserialize are available
if (typeof v8Module.serialize === 'function' && typeof v8Module.deserialize === 'function') {
// Perform a self-test to verify V8 serialization works correctly
// This catches cases like Jest's VM context where V8 serialization
// produces data that deserializes incorrectly (Maps become plain objects)
// Use Object.prototype.toString for cross-VM-context detection instead of
// instanceof, which fails in Jest's sandboxed VM where the Map class from
// v8.deserialize differs from the test environment's Map class.
const testMap = new Map([['__test__', 1]]);
const testBuffer = v8Module.serialize(testMap);
const testRestored = v8Module.deserialize(testBuffer);

if (testRestored instanceof Map && testRestored.get('__test__') === 1) {
if (Object.prototype.toString.call(testRestored) === '[object Map]' &&
testRestored.get('__test__') === 1) {
useV8 = true;
} else {
// V8 serialization is broken in this environment (e.g., Jest)
// V8 serialization is truly broken in this environment
useV8 = false;
}
}
Expand Down Expand Up @@ -157,9 +159,11 @@ function wrapForV8(value, seen = new WeakMap()) {
}

// V8 handles these natively
if (value instanceof Date || value instanceof RegExp || value instanceof Error ||
value instanceof Map || value instanceof Set ||
ArrayBuffer.isView(value) || value instanceof ArrayBuffer) {
// Use Object.prototype.toString for cross-VM-context detection (Jest sandbox)
const tag = Object.prototype.toString.call(value);
if (tag === '[object Date]' || tag === '[object RegExp]' || tag === '[object Error]' ||
tag === '[object Map]' || tag === '[object Set]' ||
ArrayBuffer.isView(value) || tag === '[object ArrayBuffer]') {
return value;
}

Expand Down Expand Up @@ -219,9 +223,11 @@ function unwrapFromV8(value, seen = new WeakMap()) {
}

// V8 restores these natively
if (value instanceof Date || value instanceof RegExp || value instanceof Error ||
value instanceof Map || value instanceof Set ||
ArrayBuffer.isView(value) || value instanceof ArrayBuffer) {
// Use Object.prototype.toString for cross-VM-context detection
const tag = Object.prototype.toString.call(value);
if (tag === '[object Date]' || tag === '[object RegExp]' || tag === '[object Error]' ||
tag === '[object Map]' || tag === '[object Set]' ||
ArrayBuffer.isView(value) || tag === '[object ArrayBuffer]') {
return value;
}

Expand Down
Loading