Edit profile page clean-up#1933
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… and adjust follower fetching logic
jicruz96
requested review from
Mephistic,
alexjball,
kiminkim724,
mertbagt,
mvictor55,
nesanders,
sashamaryl and
timblais
as code owners
Mephistic
left a comment
Mephistic
left a comment
There was a problem hiding this comment.
💯 Love this, thanks for jumping on this cleanup! Only blocker I see on merging this is fixing the broken translation keys.
| <OutlineButton | ||
| className="col-3 ms-auto" | ||
| onClick={onCancel} | ||
| label={t("confirmation.no")} |
There was a problem hiding this comment.
nit: The translation keys for confirmation are in the editProfile json file, not the common file - so these lookups won't work. We either need to move these keys to common or include editProfile as a translation root. Given that we use the Follow buttons outside of the edit profile page (even if we don't have confirmation modals enabled in those places at the moment), my vote would be for moving the keys to common.
|
These changes were merged in #2092 - I just tweaked the one outstanding copy issues and rebased this PR - going to close this. |
2 participants
Summary
PaginatedItemsCardfor generic paginated lists with loading/error statesFollowUserCardfor rendering user profiles with follow buttonsFollowUserButtonandFollowBillButtonfor consistent follow/unfollow button behavior with optional confirmation modalsWalkthrough
PaginatedItemsCardcomponent (components/shared/PaginatedItemsCard.tsx)PaginatedItemsCardresponsible for pagination state, loading/error messaging, and rendering arbitrary item cards.FollowUserCardcomponents (components/EditProfilePage/FollowUserCard.tsx)FollowingTabandFollowersTab.components/EditProfilePage/FollowingTab.tsx)PaginatedItemsCardto render bill and profiles.FollowingTabComponents/UnfollowModal(both deleted).components/EditProfilePage/FollowersTab.tsx)PaginatedItemsCard.components/shared/FollowButton.tsx)BaseFollowButton.BaseFollowButtonso screens can opt-in to confirmation easily.FollowUserButton/FollowBillButton.components/shared/FollowingQueries.tsx)PolicyActions+TestimonyDetailPageswitch to the new helpers.