Conversation
k-impossible
approved these changes
Apr 14, 2025
Collaborator
k-impossible
left a comment
k-impossible
left a comment
There was a problem hiding this comment.
고생하셨습니다! 메인 배너가 더 잘나올것 같네요
| key={index} | ||
| className={`absolute inset-0 transition-opacity duration-1000 ${ | ||
| index === currentIndex ? "z-10 opacity-100" : "z-0 opacity-0" | ||
| }`} |
| initial={{ y: "110%" }} | ||
| animate={{ y: "0%" }} | ||
| exit={{ y: "-120%" }} | ||
| transition={{ duration: 0.5, ease: "easeInOut" }} |
Collaborator
There was a problem hiding this comment.
transition을 줘도 사진 넘어가는거랑 글자 바뀌는 타이밍이 잘 맞던가요?
Collaborator
Author
There was a problem hiding this comment.
타이밍은 잘 맞고 있습니다 머지하면 한번 확인부탁드려요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
이미지 로드 및 UX 개선
PR 유형
어떤 변경 사항이 있나요?
스크린샷 및 세부 내용 - 왜 해당 PR이 필요한지 자세하게 설명해주세요
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
코드리뷰 검토 사항을 적어주세요