Enhance Regex for Filename Parsing in Multilang#31
Open
NekoOs wants to merge 1 commit intocodenautas:masterfrom
Open
Enhance Regex for Filename Parsing in Multilang#31NekoOs wants to merge 1 commit intocodenautas:masterfrom
NekoOs wants to merge 1 commit intocodenautas:masterfrom
Conversation
Updated the regular expression in the `obtainLangs` function within `multilang.js` to better handle filenames with spaces, periods, and paths. The previous regex pattern `/([a-z]{2}):([^.]+\.(md|html))/g` was limited in that it did not support filenames containing periods outside of the extension or spaces. The new pattern `/([a-z]{2}):(.+?\.(md|html))/g` allows for filenames with multiple periods and spaces, accommodating more complex file naming conventions and paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request updates the regex used in the
obtainLangsfunction ofmultilang.jsto better handle a variety of filename conventions. The update is critical for projects that include files with complex names or paths.Changes
/([a-z]{2}):([^.]+\.(md|html))/gto/([a-z]{2}):(.+?\.(md|html))/g.Rationale
The previous regex failed to parse filenames with periods that were not at the position of the file extension (e.g.,
example.test.md) and did not support filenames with spaces or paths (e.g.,../my docs/example.md). These limitations hindered the usability of the multilang library in environments where file naming conventions vary and include more complex structures.Benefits
This update is crucial for users who manage documentation in multiple languages across various directories and naming conventions, ensuring broader usability and fewer errors in file processing.