Conversation
github-actions
bot
force-pushed
the
auto-cleanup
branch
9 times, most recently
from
e189eda to
d4c61c6
Compare
github-actions
bot
force-pushed
the
auto-cleanup
branch
20 times, most recently
from
ed0fc4f to
9fb6874
Compare
github-actions
bot
force-pushed
the
auto-cleanup
branch
17 times, most recently
from
82a5b7e to
297c0e5
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 297c0e5298
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Fixed: restored |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
github-actions
bot
force-pushed
the
auto-cleanup
branch
from
2c55d35 to
2eb54f2
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
github-actions
bot
force-pushed
the
auto-cleanup
branch
from
708099a to
2eb54f2
Compare
ConnectionStatus and ConnectionHealth were identically defined in both sshConnectionPool.ts and SSH2ConnectionPool.ts. Since SSH2ConnectionPool already imports SSHConnectionConfig from sshConnectionPool, extend the import to include ConnectionHealth (ConnectionStatus is used transitively through ConnectionHealth, so no direct import needed).
…teRanking After PR #2492 introduced commandPaletteRanking.ts, the higher-level wrappers fuzzySubsequenceMatch, matchesAllTerms, scoreAllTerms (and the private fuzzySubsequenceMatchNormalized) lost all production callers. Remove the dead functions and their corresponding tests. The low-level primitives (normalizeFuzzyText, splitQueryIntoTerms, scoreSingleTermNormalized) remain — they are actively used by commandPaletteRanking.ts.
github-actions
bot
force-pushed
the
auto-cleanup
branch
from
2eb54f2 to
8fe6c3f
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Summary
Periodic auto-cleanup: remove dead code, fix stale config, deduplicate helpers, and tighten module exports.
Latest Change
fuzzySearch.ts: After PR 🤖 fix: rank command palette results by fuzzy match quality #2492 introducedcommandPaletteRanking.ts, the higher-level wrappersfuzzySubsequenceMatch,matchesAllTerms,scoreAllTerms(and privatefuzzySubsequenceMatchNormalized) lost all production callers. Removed the dead functions and their test cases (-126 LoC). The actively-used primitives (normalizeFuzzyText,splitQueryIntoTerms,scoreSingleTermNormalized) remain.Previous changes
ConnectionHealthinterface fromSSH2ConnectionPool.ts.src/common/utils/tools/taskToolTypeGuards.ts: Dead module with zero imports.src/common/utils/ai/providerFactory.ts: Dead since folder restructure.isStreamingParttype guard frommessageUtils.ts.formatDurationinto shared utility.formatNewCommand,ThemeToggleButton,canonicalModelId,hasSubtitleprop.RightSidebar.tsx.partialService.test.ts→historyService.partial.test.ts.UpdaterService.getStatus().normalizeAgentId,getProviderDisplayName,getCustomModels/getAllCustomModels.codexOauthAuth.tsand re-exports.modelEntries.ts.pendingReplayResetfield fromWorkspaceStore.ts.onLogEntry,formatPendingCommand,parseGitShowBranchForStatus, path helpers.ChatInputPropsbarrel re-export.isBashOutputTool.collectToolConfigsFromDefinitionGraphandAgentToolsLike.chatEditing.ts.Validation
make typecheckpassesmake static-checkpasses (excludingshfmtnot available in CI env)Auto-cleanup checkpoint: 29d08e3
Generated with
mux• Model:anthropic:claude-opus-4-6• Thinking:xhigh