fix: align notification timing with UI refresh and unify panel/tray sections#53
fix: align notification timing with UI refresh and unify panel/tray sections#53ibetitsmike merged 4 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5afb3b85f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/fix-notification-ui-sync
branch
from
5a74b55 to
31e5dfb
Compare
|
@codex review |
Move notification dispatch to run after state update and frontend emit but before avatar fetching and tray menu rebuild. This ensures: - UI reflects the change before the notification appears - Notifications aren't delayed by slow avatar downloads
ibetitsmike
force-pushed
the
mike/fix-notification-ui-sync
branch
from
31e5dfb to
806b44d
Compare
|
Fixed: moved notification dispatch before avatar fetch so notifications aren't delayed by slow avatar downloads. Thread resolved. @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31e5dfb76c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Previous review was on a stale commit. The current code already has notifications dispatched before avatar fetch (line 66-80 in poller.rs, avatar fetch starts at line 82). Both threads resolved. @codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f0fe8b503
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When clicking 'Recently Merged' in the tray menu, the panel opens showing only that section, expanded with all items visible. A back button returns to the full panel view. - Rust: emit show-merged event from open_panel handler - App.svelte: listen for show-merged, manage focusSection state - PRPanel: filter to focused section, show back control - PRSection: expandAll prop forces open + shows all items - Shared RECENTLY_MERGED_SECTION_TITLE constant - focusSection cleared on logout, auth-cleared, and settings nav
|
Fixed: focusSection now cleared in handleLogout() too. Thread resolved. @codex review |
ibetitsmike
force-pushed
the
mike/fix-notification-ui-sync
branch
from
5f0fe8b to
e01201f
Compare
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
What
Four improvements to notification/UI consistency and tray menu.
1. Notifications fire after UI update, before avatar fetch
Reordered the background poller so notifications fire after state update + frontend emit but before avatar fetching.
2. Added Mergeable and Checks Running sections to tray menu
Tray and panel now show the same 10 sections in the same order.
3. Recently Merged opens the panel in focused mode
Clicking Recently Merged (N) in the tray opens the panel showing only that section — expanded with all items visible. A back button returns to the full view.
4. Supporting infrastructure
RECENTLY_MERGED_SECTION_TITLEconstantexpandAllprop on PRSection (forces expanded + shows all items)focusSection/onClearFocusprops on PRPanelshow-mergedTauri event from Rust → frontendFiles changed
src-tauri/src/poller.rs,src-tauri/src/menu.rs,src-tauri/src/lib.rssrc/App.svelte,src/lib/PRPanel.svelte,src/lib/PRSection.svelte,src/lib/stores.ts,src/lib/constants.tssrc/__mocks__/tauri-api.ts,src/__mocks__/tauri-event.tssrc/App.test.ts,src/lib/components.test.ts