chore: skip pre-releases when selecting Coder versions for integration tests#497
Closed
matifali wants to merge 1 commit intofix/go-version-checkfrom
Closed
chore: skip pre-releases when selecting Coder versions for integration tests#497matifali wants to merge 1 commit intofix/go-version-checkfrom
matifali wants to merge 1 commit intofix/go-version-checkfrom
Conversation
matifali
force-pushed
the
fix/coderversion-skip-prereleases
branch
2 times, most recently
from
b55e47c to
ab96eec
Compare
…tests The coderversion script was including release candidates when scanning GitHub releases, then stripping the pre-release suffix to form the version string (e.g. v2.32.0-rc.0 → v2.32.0). This caused integration tests to pull a Docker image that doesn't exist yet, failing with "manifest unknown".
matifali
force-pushed
the
fix/coderversion-skip-prereleases
branch
from
ab96eec to
c13233f
Compare
matifali
changed the title
3 tasks
Member
|
See #498 instead |
Member
Author
|
closing in favour of #498 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
coderversionscript was picking up release candidates (e.g.v2.32.0-rc.0) from the GitHub releases API, then formatting the version without the pre-release suffix (v2.32.0). Integration tests then tried to pullghcr.io/coder/coder:v2.32.0which doesn't exist yet, failing withmanifest unknown.Fix: filter out releases where
prerelease: truein the API response.Test plan
go run ./scripts/coderversionreturns only stable versions (currentlyv2.31.5/v2.30.4/v2.29.8)manifest unknownerrors