Improve credential management: clear on logout, add switch and manage commands #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der#760) - Logout now clears stored credentials via secretsManager.clearAllAuthData() - Add "Switch Deployment" command to change deployments without clearing credentials
Replace debug-only coder.debug.listDeployments with user-facing coder.manageCredentials command. Includes "Remove All" option with confirmation dialog when multiple deployments are stored.
EhabY
changed the title
EhabY
changed the title
Collaborator
|
Is it possible to add tests for this? |
Collaborator
Author
We do not really have any |
mtojek
approved these changes
Jan 30, 2026
Member
mtojek
left a comment
mtojek
left a comment
There was a problem hiding this comment.
👍
I agree with Danielle's take on testing, we may need to consider mocking vscode.window sooner than later
johnstcn
reviewed
Jan 30, 2026
EhabY
force-pushed
the
clear-credentials-on-logout
branch
from
18a3c44 to
362b397
Compare
Collaborator
Author
|
Created #769 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Logout behavior: Previously, logging out only cleared the session but left credentials stored. Now it properly clears all auth data for the deployment.
Switch Deployment: New command for users who work with multiple deployments. Allows switching without losing credentials for other deployments.
Manage Stored Credentials: Replaces the debug-only
coder.debug.listDeploymentscommand with a user-facing command that:Fixes #760