Issue 80 and 81: Art in Game Showcase and Individual Game Pages#138
Open
nicostellar wants to merge 29 commits intomainfrom
Open
Issue 80 and 81: Art in Game Showcase and Individual Game Pages#138nicostellar wants to merge 29 commits intomainfrom
nicostellar wants to merge 29 commits intomainfrom
Conversation
…hen GameArtCarousel UI component call for display
…s will look if art is less than 4
… with hover effect, on desktop 4 artwork are displayed, clean coding for easy readability
…ame group div the elements have a gap of 8
… issue-81-Art_in_Gameshowcase_GameSerializer_Data The issue-81-Incorporate_art_into_gameShowcase_page_2 branch is the current working branch. Testing feedback to make GameSerializer incorporate the art data instead of frontend filter
…e-40 branch by artwork team
… issue-8-merge-40 branch) to GameSerializer so that artworks can be grouped and sent when frontend calls for a game
…r and is converted into UiArtwork by transformApiGameToUiGame (used by GameArtCarousel)
…ld after discussion from Art Team
…to get all artwork of all games in gameshowcase
…s for single source of truth
…into UiArtworks and normalize media paths into full image urls
…into UiArtworks and normalize media paths into full image urls
…ializer for art filtering by game
…howcase_GameSerializer_Data
…ixed, gameshowcase has artwork now
…ratio of image to textbox and a scalable gap between the text and contributors. The social icons now align on the right. Mobile layout still needs to be adjusted.
…out to suit mobile devices.
…howcase_GameSerializer_Data
Collaborator
Author
|
Main has been merged into this branch but there are issues with duplicate and missing migration files. Waiting for PR #136 to be approved which restructures the migration files to resolve these issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR incorporates the art showcase into both the games showcase and individual game pages. There is an image carousel on each page that shows several art images. Clicking on an artwork image will navigate to the individual art page.
Back-end
GameArtSerializerfor individual game pages and game showcase.GameArtSerializeris inside theGameSerializerandGameShowcaseSerializerso the existing API can send the info from the game and art together.Front-end
GameArtCarouselwas created to display the artworks inside the game showcase and individual game pages.useGames.tswas created to take data fromGameSerializerfor individual games and pass it to the frontend.GameArtCarouseland then displays the art.Change Form
Related Issues