Skip to content

Fix: accessible code snippets toolbar #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imantsk merged 2 commits into from
Apr 14, 2026
Merged

Fix: accessible code snippets toolbar #345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e53ced
Fix: accessible code snippets toolbar
rami-elementor Apr 10, 2026
fecb95e
Update `aria-labels`
rami-elementor Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 23 additions & 20 deletions src/js/components/common/Toolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,13 @@ const UpperNav: React.FC<NavProps> = ({ setIsUpsellDialogOpen }) =>
<img
src={`${window.CODE_SNIPPETS?.urls.plugin}/assets/icon.svg`}
alt={__('Code Snippets logo', 'code-snippets')}
aria-hidden="true"
/>

<h1>{__('Code Snippets', 'code-snippets')}</h1>
</div>

<nav>
<nav aria-label={__('Main links', 'code-snippets')}>
<ul>
{UPPER_NAV_LINKS.map(({ name, url, label, external }) =>
<li key={name}>
Expand Down Expand Up @@ -119,25 +120,27 @@ const currentPage = fetchQueryParam('subpage') ?? fetchQueryParam('page')

const LowerNav: React.FC<NavProps> = ({ setIsUpsellDialogOpen }) =>
<div className="code-snippets-toolbar-lower">
<ul>
{LOWER_NAV_LINKS.map(({ name, url, label, pro, icon }) =>
<li key={name}>
<a
href={url ?? buildUrl(window.CODE_SNIPPETS?.urls.manage, { subpage: name })}
className={classnames(`${name}-link`, { 'active-link': currentPage?.endsWith(name) })}
onClick={event => {
if (pro && !isLicensed()) {
event.preventDefault()
setIsUpsellDialogOpen(true)
}
}}
>
{icon}
<span>{label}</span>
{pro && !isLicensed() && <span className="pro-chip">{__('Pro', 'code-snippets')}</span>}
</a>
</li>)}
</ul>
<nav aria-label={__('Main features', 'code-snippets')}>
<ul>
{LOWER_NAV_LINKS.map(({ name, url, label, pro, icon }) =>
<li key={name}>
<a
href={url ?? buildUrl(window.CODE_SNIPPETS?.urls.manage, { subpage: name })}
className={classnames(`${name}-link`, { 'active-link': currentPage?.endsWith(name) })}
onClick={event => {
if (pro && !isLicensed()) {
event.preventDefault()
setIsUpsellDialogOpen(true)
}
}}
>
{icon}
<span>{label}</span>
{pro && !isLicensed() && <span className="pro-chip">{__('Pro', 'code-snippets')}</span>}
</a>
</li>)}
</ul>
</nav>
</div>

export const Toolbar = () => {
Expand Down
Loading