Skip to content

Fix: accessible navigation tab wrappers #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imantsk merged 2 commits into from
Apr 14, 2026
Merged

Fix: accessible navigation tab wrappers #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d902404
Fix: accessible navigation tab wrappers
rami-elementor Apr 12, 2026
7ad1990
Merge branch 'core-beta' into a11y-nav-tab-wrapper
imantsk Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/css/import/_page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
max-inline-size: 800px;
}

h2.nav-tab-wrapper {
.nav-tab-wrapper {
margin-block-end: 20px;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/css/manage.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
line-height: 1.4;
}

.wrap h2.nav-tab-wrapper {
.wrap .nav-tab-wrapper {
.nav-tab {
display: flex;
flex-flow: row wrap;
Expand Down
7 changes: 5 additions & 2 deletions src/js/components/ImportMenu/ImportMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ export const ImportMenu: React.FC = () => {
<h1>{__('Import Snippets', 'code-snippets')}</h1>

<div className="narrow">
<h2 className="nav-tab-wrapper">
<nav
className="nav-tab-wrapper"
aria-label={__('Import sources', 'code-snippets')}
>
{TABS.map(tab =>
<button
key={tab}
Expand All @@ -50,7 +53,7 @@ export const ImportMenu: React.FC = () => {
>
{TAB_LABELS[tab]}
</button>)}
</h2>
</nav>

<WithRestAPIContext>
{TABS.map(tab =>
Expand Down
7 changes: 5 additions & 2 deletions src/js/components/ManageMenu/CommunityCloud/CommunityCloud.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ export const CommunityCloud = () => {
<div className="wrap">
<h1>{__('Community Cloud', 'code-snippets')}</h1>

<h2 className="nav-tab-wrapper">
<nav
className="nav-tab-wrapper"
aria-label={__('Community Cloud types', 'code-snippets')}
>
{TABS.map(tab =>
<a
key={tab}
Expand All @@ -46,7 +49,7 @@ export const CommunityCloud = () => {
{TAB_LABELS[tab]}
{PRO_TABS.includes(tab) && !isLicensed() && <span className="pro-chip">{__('Pro', 'code-snippets')}</span>}
</a>)}
</h2>
</nav>

{'snippets' === currentTab
? <WithRestAPIContext>
Expand Down
7 changes: 5 additions & 2 deletions src/js/components/ManageMenu/SnippetsTable/SnippetsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,14 @@ const SnippetsTableInner = () => {
<div className="wrap">
<PageHeading />

<h2 className="nav-tab-wrapper snippet-type-tabs">
<nav
className="nav-tab-wrapper snippet-type-tabs"
aria-label={__('Snippet types', 'code-snippets')}
>
<SnippetTypeTab setIsUpgradeDialogOpen={setIsUpgradeDialogOpen} />
{SNIPPET_TYPES.map(type =>
<SnippetTypeTab key={type} type={type} setIsUpgradeDialogOpen={setIsUpgradeDialogOpen} />)}
</h2>
</nav>

<WithFilteredSnippetsContext>
<SnippetsListTable />
Expand Down
4 changes: 2 additions & 2 deletions src/php/Admin/Menus/Settings_Menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ protected function do_settings_tabs() {
$sections = $this->get_sections();
$active_tab = $this->get_current_section();

echo '<h2 class="nav-tab-wrapper" id="settings-sections-tabs">';
echo '<nav class="nav-tab-wrapper" id="settings-sections-tabs" aria-label="' . esc_attr__( 'Settings tabs', 'code-snippets' ) . '">';

foreach ( $sections as $section ) {
printf(
Expand All @@ -266,7 +266,7 @@ protected function do_settings_tabs() {
);
}

echo '</h2>';
echo '</nav>';

foreach ( $sections as $section ) {
if ( 'license' === $section['id'] ) {
Expand Down
Loading