Fix: remove Enter key handling from ConfirmDialog component#357
Open
rami-elementor wants to merge 1 commit intocore-betafrom
Open
Fix: remove Enter key handling from ConfirmDialog component#357rami-elementor wants to merge 1 commit intocore-betafrom
rami-elementor wants to merge 1 commit intocore-betafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ConfirmDialog.tsxcapturesonKeyDownto trigger dialog confirmation.The issue is that
onKeyDowncaptures Enter globally within the modal.This can conflict with screen reader virtual buffer navigation and activate the confirm action unintentionally.
To avoid unintentional activation, the dialog should capture Enter key only when focus is on the confirm button, or use native button activation behavior.