Open
Conversation
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates installer/bootstrap logic to avoid regenerating PostgreSQL TLS assets unnecessarily and fixes vault rewriting behavior by extracting secrets into a fresh vault, with added validation and regression tests.
Changes:
- Switch vault writing to use
RootConfig.ExtractVault()(avoids duplicate secret entries on re-write). - Add
ValidateCertKeyPairand enforce cert/key validation during secret generation and GCP bootstrap updates. - Add tests covering cert/key validation and bootstrap “re-run” scenarios.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| NOTICE | Updates dependency/version entries and license URLs. |
| internal/tmpl/NOTICE | Mirrors NOTICE dependency/version updates in the template. |
| internal/installer/crypto.go | Adds ValidateCertKeyPair helper using tls.X509KeyPair. |
| internal/installer/crypto_test.go | Adds tests for matching/mismatched/invalid cert+key inputs. |
| internal/installer/config_manager.go | Writes vault from a freshly extracted vault instead of mutating existing vault. |
| internal/installer/config_manager_test.go | Extends mock FileIO + adds tests for vault de-dup and bootstrap re-run simulation. |
| internal/installer/config_manager_secrets.go | Validates generated Postgres cert/key pairs. |
| internal/bootstrap/gcp/install_config.go | Avoids regenerating Postgres certs unless inputs changed or key missing; validates pairs when generated. |
| internal/bootstrap/gcp/install_config_test.go | Adds coverage for “ExistingConfigUsed” certificate regeneration rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…-only secrets in WriteVault
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
joka134
reviewed
Apr 10, 2026
Member
joka134
left a comment
joka134
left a comment
There was a problem hiding this comment.
Nice! Left a few comments, but still approved
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clickup