Tika 3.1, Pac4j 6.1.2, Nimbus 11.24, Bouncy Castle 1.80, POI 5.3 Upgrades#6913
Open
derekwilhelm wants to merge 8 commits intocodice:2.29.xfrom
Open
Tika 3.1, Pac4j 6.1.2, Nimbus 11.24, Bouncy Castle 1.80, POI 5.3 Upgrades#6913derekwilhelm wants to merge 8 commits intocodice:2.29.xfrom
derekwilhelm wants to merge 8 commits intocodice:2.29.xfrom
Conversation
Contributor
Author
|
build now |
malmgrens4
approved these changes
May 19, 2025
ahoffer
reviewed
May 19, 2025
pom.xml
Outdated
| <artifactId>apache-mime4j-dom</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </exclusions>--> |
Contributor
There was a problem hiding this comment.
Is the commented-out code remaining for a reason?
Contributor
Author
There was a problem hiding this comment.
no, just forgot to remove it
ahoffer
reviewed
May 19, 2025
| <bundle>wrap:mvn:net.sf.jwordnet/jwnl/${jwnl.version}</bundle> | ||
| <bundle>mvn:org.apache.tika/tika-core/${tika.version}</bundle> | ||
| <bundle>mvn:org.apache.tika/tika-bundle-standard/${tika.version}</bundle> | ||
| <bundle>wrap:mvn:org.apache.tika/tika-bundle-standard/${tika.version}$overwrite=merge&Import-Package=!org.junit,!org.junit.*,!junit.*,org.github.javaparser.resolution.*;resolution:=optional,org.apache.tika.*,org.slf4j,org.slf4j.event,org.slf4j.helpers,*;resolution:=optional</bundle> |
Contributor
There was a problem hiding this comment.
That is some serious Kung Fu.
ahoffer
approved these changes
May 19, 2025
Member
|
build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI. |
clockard
approved these changes
May 21, 2025
Contributor
|
build now |
|
Internal build has been started, your results will be available at build completion. |
|
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrades Tika to version 3.1.0
Upgrades Pac4j to version 6.1.2
Upgrades Nimbus to version 11.24
Upgrades Bouncy Castle to version 1.80
Upgrades Apache POI to version 5.3.0
Upgrades PDFBox to version 3.0.5
Who is reviewing it?
@glenhein
@pklinef
@jlcsmith
Select relevant component teams:
@codice/data
@codice/security
Ask 2 committers to review/merge the PR and tag them here.
@ahoffer
@clockard
How should this be tested?
Any background context you want to provide?
What are the relevant tickets?
Fixes: #____
Screenshots
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: