Remove asm feature for sha2 depend on Windows platform#106
Closed
windowsair wants to merge 1 commit intocollabora:mainfrom
Closed
Remove asm feature for sha2 depend on Windows platform#106windowsair wants to merge 1 commit intocollabora:mainfrom
windowsair wants to merge 1 commit intocollabora:mainfrom
Conversation
The upstream sha2 is not support asm feature for Windows platform, disable it[0]. [0]: RustCrypto/hashes#283
obbardc
approved these changes
Dec 20, 2025
Contributor
Contributor
|
Thanks for the contribution; Finally got some time to pick my backlog. It seems that in the last version of the sha2 create this feature has been removed entirely, which hopefully means with #121 things should just work on windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream sha2 is not support asm feature for Windows platform, disable it. RustCrypto/hashes#283