Support _htmlBlockType for html_inline.#97
Open
tmpfs wants to merge 4 commits intocommonmark:masterfrom
Open
Conversation
Add support for the _htmlBlockType property on inline HTML elements; this allows AST consumers to be able to know ahead of time the type for inline HTML elements which is useful when parsing processing instructions or comments. Moved the reHtmlBlockOpen RegExp to the common module so that it may be shared between the inline and block parsers.
Contributor
Author
|
Benchmarks were stable for me after adding this but I'm not sure which sample to use for lots of inline HTML elements. |
HTML5 allows the lowercase version `<!doctype html>`.
When determining _htmlBlockType for html_inline node types.
|
@jgm any chance for this PR to be merged ? (once fixed, obviously) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the _htmlBlockType property on inline HTML elements;
this allows AST consumers to be able to know ahead of time the type for
inline HTML elements which is useful when parsing processing
instructions or comments.
Moved the reHtmlBlockOpen RegExp to the common module so that it may be
shared between the inline and block parsers.