Merge upstream updates, bump dependencies, and refactor code and unit tests#5
Merged
marcransome merged 16 commits intomasterfrom Mar 2, 2026
Merged
Merge upstream updates, bump dependencies, and refactor code and unit tests#5marcransome merged 16 commits intomasterfrom
marcransome merged 16 commits intomasterfrom
Conversation
|
Image build success |
bcullerton
previously approved these changes
Feb 11, 2026
|
Image build success |
|
Image build success |
bcullerton
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes incorporate upstream updates, dependency version bumps, and refactoring across the codebase and unit tests to improve maintainability and mitigate vulnerabilities. This includes the following changes:
Dockerfileto usenode:25-alpinebase image.npm.coverallsdue to dependency onrequest1 package.request1 andrequest-promise1 withgotversion^11.8.6; this is the last known version to support CommonJS at this time, newer versions are ESM-only.bin/out.js, replacingrequest-promiserelated logic with equivalent logic usinggotpromises.js-combinatoricswith inline functioncombinations()in unit test file;js-combinatoricsuses heuristics that incorrectly treat the array of strings namedrequiredas a scalar leading toBigIntconversion failures.stdinrelated statements in acli_mode_only()function inbin/out.jsto avoid creating TTY handles when running in a test environment, which would otherwise remain open and lead toTTYWRAPfailures when runningnpm test.eslint.config.cjs) and replaced deprecated--ignore-pathflag frompretestscript with explicitcoverage/**ignore rule.Content-Typeheader for webhook requests toapplication/x-www-form-urlencoded(i.e. parameterpayload_content_typedefaults toform); this is a requirement of ci-webhook-trigger.CODEOWNERSconfiguration and updated branch protection rules to require reviews from designated code owners.overridestopackage.jsonto mitigate CVE-2026-26996Resolves:
DVOP-4179.Footnotes
requestandrequest-promiseare deprecated and exhibit known vulnerabilities; see https://github.com/request/request/issues/3142. ↩ ↩2 ↩3