fix: Move runtime codes to own separate header file#859
Open
aniruddhaadak80 wants to merge 1 commit intocompiler-research:mainfrom
Open
fix: Move runtime codes to own separate header file#859aniruddhaadak80 wants to merge 1 commit intocompiler-research:mainfrom
aniruddhaadak80 wants to merge 1 commit intocompiler-research:mainfrom
Conversation
Vipul-Cariappa
requested changes
Mar 23, 2026
Collaborator
Vipul-Cariappa
left a comment
Vipul-Cariappa
left a comment
There was a problem hiding this comment.
Other than the folder structure change, this is fine, I guess.
But I am now worried about starting the interpreter with the correct include paths.
This is currently running fine, because we are doing a source build with the env var CPLUS_INCLUDE_PATH set to point to the necessary things.
But what happens when we do a conda install? I don't think this will work out of the box without modifications to CreateInterpreter logic to include this directory.
| @@ -0,0 +1,22 @@ | |||
| //===--- CppInterOpRuntime.h - Runtime codes for language interoperability ---*- C++ -*-===// | |||
Collaborator
There was a problem hiding this comment.
Can this file go to include/CppInterOp/runtime/CppInterOpRuntime.h.
Collaborator
|
I'd like to point out that a PR addressing this was already opened: #761 that wasn't reviewed. cc @Vipul-Cariappa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #697
Description
This addresses #697, which required extracting the dynamically declared code block inside
CppInterOp.cpp(the__internal_CppInterOpwrapper signatures) out into its own dedicated header file.Changes Made
include/CppInterOp/CppInterOpRuntime.hto house the runtime code signatures.I->declarepayload inCppInterOp.cppwith a standard runtime#include <CppInterOp/CppInterOpRuntime.h>preprocessor directive.This cleans up the interpreter startup code and makes extending the runtime capabilities much easier.