CIVIMM-462: Fix processor type name from Stripe to Stripe Connect

[erawat]

Overview

The instalment generation job was finding zero eligible recurring contributions because it filtered by PaymentProcessorType.name = 'Stripe', but the actual type name registered in the database is 'Stripe Connect'.

Before

• Job runs and processes 0 recurring contributions
• processor_type=Stripe does not match PaymentProcessorType.name = 'Stripe Connect'

After

• Job correctly matches the Stripe Connect processor type
• Instalment contributions are generated as expected

Technical Details

• Updated DEFAULT_PROCESSOR_TYPE constant in InstalmentGenerationService from 'Stripe' to 'Stripe Connect'
• Updated the managed job definition (Job_InstalmentGenerator.mgd.php) parameter default to match

Comments

• The Job_InstalmentCharge.mgd.php has the same processor_type=Stripe mismatch — this should be addressed in a follow-up
• Unit tests use the Dummy processor type so this mismatch was not caught in CI

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical configuration error that prevented the instalment generation job from functioning correctly. By standardizing the payment processor type name to 'Stripe Connect' across both the service logic and the job definition, the system can now accurately identify and process recurring contributions, ensuring proper instalment generation.

Highlights

• Processor Type Correction: The DEFAULT_PROCESSOR_TYPE constant in InstalmentGenerationService was updated from 'Stripe' to 'Stripe Connect' to match the actual name used in the database.
• Job Configuration Update: The Job_InstalmentGenerator managed job definition was modified to use 'Stripe Connect' for its processor_type parameter, ensuring it correctly identifies eligible recurring contributions.
• Instalment Generation Fix: This change resolves an issue where the instalment generation job was failing to process recurring contributions due to a mismatch in the payment processor type name.

Changelog

• Civi/Paymentprocessingcore/Service/InstalmentGenerationService.php
  • Updated the DEFAULT_PROCESSOR_TYPE constant from 'Stripe' to 'Stripe Connect'.
• managed/Job_InstalmentGenerator.mgd.php
  • Modified the parameters field to set processor_type to 'Stripe Connect' instead of 'Stripe'.

Activity

• The pull request was created by erawat to fix a critical issue with instalment generation.
• The author provided a detailed overview, before/after scenarios, and technical details in the PR description.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a bug where the instalment generation job was failing due to an incorrect payment processor type name. The changes from 'Stripe' to 'Stripe Connect' in both the service constant and the managed job definition are appropriate. I have added one review comment regarding the addition of a regression test, which is a recommended practice for bug fixes according to the repository's style guide.