Add unit tests for ToggleFullScreen hotkey (PR #587)#2
Draft
Add unit tests for ToggleFullScreen hotkey (PR #587)#2
Conversation
Co-authored-by: computerman0 <111095231+computerman0@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Build and test the newest pull request
Add unit tests for ToggleFullScreen hotkey (PR #587)
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR dpaulat#587 added
ToggleFullScreento theHotkeyenum with F11 as its default binding, but no tests covered the new enum value, its name mappings, or its inclusion in theHotkeyIteratorrange.Changes
test/source/scwx/qt/types/hotkey_types.test.cpp(new): Tests for theToggleFullScreenhotkey:"toggle_full_screen"/"Toggle Full Screen")GetHotkeyFromShortName/GetHotkeyFromLongNameHotkeyIteratorrange includesHotkey::ToggleFullScreentest/test.cmake: AddsSRC_QT_TYPES_TESTSvariable and wires the new test file into thewxtesttarget with aSource Files\\qt\\typessource group.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.