support cpu idle and burst for cgroupv2#323
Open
zouyee wants to merge 3 commits intocontainerd:mainfrom
Open
Conversation
Signed-off-by: zouyee <zouyee1989@gmail.com>
Contributor
Author
|
/assign @AkihiroSuda @fuweid |
Member
|
I'm having trouble finding the kernel docs on these. Have any pointers? |
Contributor
Author
sched: Cgroup SCHED_IDLE support is introduced in Linux 5.15 Burstable CFS controller is landed in Linux 5.14 |
Contributor
Author
cpuguy83
requested changes
Jan 31, 2024
Signed-off-by: zouyee <zouyee1989@gmail.com>
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
cpuguy83
reviewed
Jan 22, 2025
| // if CPUWeight == 0, cpu.idle is set to 1; | ||
| // if CPUWeight != 0, cpu.idle is set to 0. | ||
| // Do not add duplicate CPUWeight property | ||
| if resources.CPU.Idle != nil && resources.CPU.Weight != nil && *resources.CPU.Weight != 0 { |
Member
There was a problem hiding this comment.
I'm not following this logic.
Right now if resources.CPU.Idle is set and resources.CPU.Weight is set to a non-zero value then we end up with CPUWeight being set twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.